npawar commented on a change in pull request #3618: Refactor
ControllerPeriodicTask to iterate over tables
URL: https://github.com/apache/incubator-pinot/pull/3618#discussion_r242734100
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/helix/core/relocation/RealtimeSegmentRelocator.java
##########
@@ -58,51 +58,59 @@ public RealtimeSegmentRelocator(PinotHelixResourceManager
pinotHelixResourceMana
}
@Override
- public void process(List<String> tables) {
- runRelocation(tables);
+ protected void preprocess() {
+
+ }
+
+ @Override
+ protected void process(String tableNameWithType) {
+ runRelocation(tableNameWithType);
+ }
+
+ @Override
+ protected void postprocess() {
+
Review comment:
Yes, that is a good idea. Will do so in a future PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
