codecov-io edited a comment on issue #3618: Refactor ControllerPeriodicTask to iterate over tables URL: https://github.com/apache/incubator-pinot/pull/3618#issuecomment-448399940 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=h1) Report > Merging [#3618](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/0146e5fc82ea3c466b5c3a30618a8456a76cd686?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `62.43%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3618 +/- ## ============================================ + Coverage 70.66% 70.66% +<.01% Complexity 4 4 ============================================ Files 1011 1011 Lines 46413 46415 +2 Branches 6212 6208 -4 ============================================ + Hits 32798 32801 +3 - Misses 11456 11459 +3 + Partials 2159 2155 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `26.42% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `76.31% <100%> (+3.23%)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `97.61% <100%> (+0.39%)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `70.83% <4.76%> (-9.38%)` | `0 <0> (ø)` | | | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvbWluaW9uL1Bpbm90VGFza01hbmFnZXIuamF2YQ==) | `87.75% <76.92%> (+4.08%)` | `0 <0> (ø)` | :arrow_down: | | [...n/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L1NlZ21lbnRTdGF0dXNDaGVja2VyLmphdmE=) | `84.37% <83.5%> (-0.25%)` | `0 <0> (ø)` | | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `82.22% <0%> (-13.34%)` | `0% <0%> (ø)` | | | [...inkedin/pinot/common/config/RealtimeTagConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9jb25maWcvUmVhbHRpbWVUYWdDb25maWcuamF2YQ==) | `93.33% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `86.66% <0%> (-6.67%)` | `0% <0%> (ø)` | | | ... and [28 more](https://codecov.io/gh/apache/incubator-pinot/pull/3618/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=footer). Last update [0146e5f...a991874](https://codecov.io/gh/apache/incubator-pinot/pull/3618?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
