aaronucsd commented on a change in pull request #3619:  [TE] get all 
subscription groups endpoint
URL: https://github.com/apache/incubator-pinot/pull/3619#discussion_r242755197
 
 

 ##########
 File path: 
thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/detection/DetectionResource.java
 ##########
 @@ -138,6 +137,16 @@ public Response getSubscriptionGroups(@ApiParam("the 
detection config id") @Path
     return Response.ok(new ArrayList<>(subscriptionGroupAlertDTOs)).build();
   }
 
+
+  @Path("/subscription-groups")
 
 Review comment:
   Are we following this pattern like `GET /detection/subscription-groups/`? 
Under `detection`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to