aaronucsd commented on issue #3620: [TE] frontend - harleyjj/rootcause-visual - 
componentize rootcause gr…
URL: https://github.com/apache/incubator-pinot/pull/3620#issuecomment-448701092
 
 
   > @harleyjj I be glad to get more background on this. I understand you want 
to integrate the chart with the "Manage Alert" page, but I don't get how 
comparison range and legend are useful for this. Ultimately I wonder what's the 
value-add of this component. It doesn't seem to add any kind of shared state or 
interaction between the sub-components.
   
   @apucher I think @harleyjj is trying to make the two charts or all the 
charts be consistent with using the same chart component. I agree that the 
range comparison doesn't make sense. We might want to exempt that from this 
component. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to