sunithabeeram commented on a change in pull request #3622: Start and stop
ControllerPeriodicTasks based on leadership changes
URL: https://github.com/apache/incubator-pinot/pull/3622#discussion_r243358009
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/periodictask/PeriodicTaskScheduler.java
##########
@@ -70,11 +73,19 @@ public void start(List<PeriodicTask> periodicTasks) {
}
}
+ /**
+ * Shutdown executor service and stop the periodic tasks
+ */
Review comment:
Do we need synchronization between start and stop? What if the leadership
change happens quickly and start is still exeucting, when stop kicks in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
