codecov-io edited a comment on issue #3622: Start and stop ControllerPeriodicTasks based on leadership changes URL: https://github.com/apache/incubator-pinot/pull/3622#issuecomment-448859489 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@39e3360`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `68.67%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3622 +/- ## ========================================= Coverage ? 70.92% Complexity ? 4 ========================================= Files ? 1012 Lines ? 46445 Branches ? 6212 ========================================= Hits ? 32939 Misses ? 11340 Partials ? 2166 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvbWluaW9uL1Bpbm90VGFza01hbmFnZXIuamF2YQ==) | `86% <0%> (ø)` | `0 <0> (?)` | | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `71.42% <100%> (ø)` | `0 <0> (?)` | | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `76.62% <100%> (ø)` | `0 <0> (?)` | | | [...m/linkedin/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJTdGFydGVyLmphdmE=) | `62.28% <100%> (ø)` | `0 <0> (?)` | | | [...n/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L1NlZ21lbnRTdGF0dXNDaGVja2VyLmphdmE=) | `89.06% <100%> (ø)` | `0 <0> (?)` | | | [.../periodictask/ControllerPeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2tTY2hlZHVsZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `68.79% <100%> (ø)` | `0 <0> (?)` | | | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `69.09% <58.53%> (ø)` | `0 <0> (?)` | | | [...pinot/core/periodictask/PeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3622/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3BlcmlvZGljdGFzay9QZXJpb2RpY1Rhc2tTY2hlZHVsZXIuamF2YQ==) | `86.11% <80%> (ø)` | `0 <0> (?)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=footer). Last update [39e3360...7cedc1b](https://codecov.io/gh/apache/incubator-pinot/pull/3622?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
