apucher closed pull request #3632: [TE] frontend - harleyjj/home - make email
share available even when …
URL: https://github.com/apache/incubator-pinot/pull/3632
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
b/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
index 674f337ca3..fbe5c1207e 100644
--- a/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/home/index/template.hbs
@@ -10,7 +10,7 @@
predefinedRanges=pill.predefinedRanges
selectAction=(action "onRangeSelection")
}}
- {{#if (gt anomaliesCount 0)}}
+ {{#if appName}}
{{#link-to "home.share-dashboard" (query-params appName=appName
duration=duration startDate=startDate endDate=endDate feedbackType=feedbackType
shareId=null) tagName="button" type="button" class="pull-right te-button
te-button--outline"}}
Share
{{/link-to}}
diff --git a/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
b/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
index 6f4f75122a..a3b362551f 100644
--- a/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/home/share-dashboard/route.js
@@ -9,7 +9,6 @@ import columns from
'thirdeye-frontend/shared/anomaliesTableColumnsShared';
import {
get,
set,
- computed,
setProperties
} from '@ember/object';
@@ -32,8 +31,8 @@ export default Route.extend(AuthenticatedRouteMixin, {
},
appName: null,
startDate: moment().subtract(1, 'day').utc().valueOf(), //taylored for Last
24 hours vs Today -> moment().startOf('day').utc().valueOf(),
- endDate: moment().utc().valueOf(),//Last 24 hours
- duration: '1d',//Last 24 hours
+ endDate: moment().utc().valueOf(), //Last 24 hours
+ duration: '1d', //Last 24 hours
feedbackType: 'All Resolutions',
shareId: null,
@@ -108,7 +107,6 @@ export default Route.extend(AuthenticatedRouteMixin, {
applicationAnomalies.forEach(anomaly => {
const metricName = get(anomaly, 'metricName');
const metricId = get(anomaly, 'metricId');
- const id = get(anomaly, 'id');
const functionName = get(anomaly, 'functionName');
const functionId = get(anomaly, 'functionId');
//Grouping the anomalies of the same metric name
@@ -140,7 +138,7 @@ export default Route.extend(AuthenticatedRouteMixin, {
this.controller.setProperties({
'shareId': null,
'showTooltip': false,
- 'shareUrl': null,
+ 'shareUrl': null
});
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
