akshayrai commented on a change in pull request #3636: [TE] frontend - aaronucsd/Basic yaml editor with alert and subscripti… URL: https://github.com/apache/incubator-pinot/pull/3636#discussion_r247678730
########## File path: thirdeye/thirdeye-frontend/app/utils/constants.js ########## @@ -139,3 +139,24 @@ rules: `; }; + +export const yamlAlertSettings = `subscriptionGroupName: test_subscription_group +cron: "0 0/5 * 1/1 * ? *" +application: "parity-check" +active: true + +detectionConfigIds: + - 5773069 + +fromAddress: [email protected] +recipients: + to: + - "[email protected]" + cc: + - "[email protected]" Review comment: This has and will potentially have a lot of LinkedIn specific things. I think we should move this out. Maybe call an endpoint and let the backend return this value. LinkedIn stuff can be easily wrapped in the backend. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
