codecov-io edited a comment on issue #3684: Add touch method in PinotFS; Call touch when moving deleted segments. URL: https://github.com/apache/incubator-pinot/pull/3684#issuecomment-453699541 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=h1) Report > Merging [#3684](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/9e82f5e8ef968184917019645140d9d8f2502908?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `21.73%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3684 +/- ## ============================================ - Coverage 67.26% 67.23% -0.04% Complexity 4 4 ============================================ Files 1027 1027 Lines 50863 50880 +17 Branches 7106 7107 +1 ============================================ - Hits 34213 34208 -5 - Misses 14307 14343 +36 + Partials 2343 2329 -14 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...main/java/org/apache/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9QaW5vdEZTLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...java/org/apache/pinot/filesystem/AzurePinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtYXp1cmUtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9BenVyZVBpbm90RlMuamF2YQ==) | `11.57% <0%> (-0.51%)` | `4 <0> (ø)` | | | [...ava/org/apache/pinot/filesystem/HadoopPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wLWZpbGVzeXN0ZW0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L2ZpbGVzeXN0ZW0vSGFkb29wUGlub3RGUy5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...java/org/apache/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvZmlsZXN5c3RlbS9Mb2NhbFBpbm90RlMuamF2YQ==) | `88.23% <100%> (+0.73%)` | `0 <0> (ø)` | :arrow_down: | | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `79.5% <50%> (+0.16%)` | `0 <0> (ø)` | :arrow_down: | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `30.76% <0%> (-43.96%)` | `0% <0%> (ø)` | | | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh) | `43.47% <0%> (-36.24%)` | `0% <0%> (ø)` | | | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `72.72% <0%> (-10.91%)` | `0% <0%> (ø)` | | | [.../apache/pinot/common/config/RealtimeTagConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JlYWx0aW1lVGFnQ29uZmlnLmphdmE=) | `93.33% <0%> (-6.67%)` | `0% <0%> (ø)` | | | ... and [30 more](https://codecov.io/gh/apache/incubator-pinot/pull/3684/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=footer). Last update [9e82f5e...8cf4d94](https://codecov.io/gh/apache/incubator-pinot/pull/3684?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
