jihaozh commented on a change in pull request #3697: [TE] - frontend
harleyjj/yaml - reset and view documentation buttons
URL: https://github.com/apache/incubator-pinot/pull/3697#discussion_r248432068
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
##########
@@ -154,16 +157,16 @@ export default Component.extend({
dataset,
id: metric.id,
completer:{
- insertMatch: (editor, data) => {
- editor.setValue(yamIt(data.metricname, data.dataset));
- editor.metricId = data.id;
- //editor.completer.insertMatch({value: data.value});
- // editor.insert('abc');
- }
- }}
- })
+ insertMatch: (editor, data) => {
+ editor.setValue(yamIt(data.metricname, data.dataset));
+ editor.metricId = data.id;
+ //editor.completer.insertMatch({value: data.value});
+ // editor.insert('abc');
Review comment:
remove commented code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
