jackjlli opened a new pull request #3711: Fix SegmentConverter to handle 
virtual column
URL: https://github.com/apache/incubator-pinot/pull/3711
 
 
   Currently the `ConvertPinotSegment` command didn't work properly with 
virtual column.
   This PR fixes this issue by removing virtual columns before writing to avro 
file.
   Error messages we found:
   ```
   $ ./pinot-distribution/target/pinot-0.016-pkg/bin/pinot-admin.sh 
ConvertPinotSegment -dataDir /input/test -outputDir /output/test -outputFormat 
avro -overwrite
   Exception caught: 
   org.apache.avro.SchemaParseException: Illegal initial character: $hostName
           at org.apache.avro.Schema.validateName(Schema.java:1064)
           at org.apache.avro.Schema.access$200(Schema.java:79)
           at org.apache.avro.Schema$Field.<init>(Schema.java:372)
           at 
org.apache.avro.SchemaBuilder$FieldBuilder.completeField(SchemaBuilder.java:2124)
           at 
org.apache.avro.SchemaBuilder$FieldBuilder.completeField(SchemaBuilder.java:2120)
           at 
org.apache.avro.SchemaBuilder$FieldBuilder.access$5200(SchemaBuilder.java:2034)
           at 
org.apache.avro.SchemaBuilder$FieldDefault.noDefault(SchemaBuilder.java:2146)
           at 
org.apache.pinot.core.util.AvroUtils.getAvroSchemaFromPinotSchema(AvroUtils.java:165)
           at 
org.apache.pinot.tools.segment.converter.PinotSegmentToAvroConverter.convert(PinotSegmentToAvroConverter.java:47)
           at 
org.apache.pinot.tools.segment.converter.PinotSegmentConvertCommand.execute(PinotSegmentConvertCommand.java:133)
           at 
org.apache.pinot.tools.admin.PinotAdministrator.execute(PinotAdministrator.java:126)
           at 
org.apache.pinot.tools.admin.PinotAdministrator.main(PinotAdministrator.java:138)
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to