mayankshriv commented on a change in pull request #3728: Support for specifying
Object Type in Schema
URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249311319
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -98,15 +102,21 @@ public FieldSpec(String name, DataType dataType, boolean
isSingleValueField) {
public FieldSpec(String name, DataType dataType, boolean isSingleValueField,
@Nullable Object defaultNullValue) {
this(name, dataType, isSingleValueField, DEFAULT_MAX_LENGTH,
defaultNullValue);
}
-
+
public FieldSpec(String name, DataType dataType, boolean isSingleValueField,
int maxLength,
@Nullable Object defaultNullValue) {
+ this(name, dataType, isSingleValueField, maxLength, defaultNullValue,
null);
+ }
+
+ public FieldSpec(String name, DataType dataType, boolean isSingleValueField,
int maxLength,
Review comment:
What's the issue with extending DataType to capture the object type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
