codecov-io edited a comment on issue #3568: Add guava cache to cache table schema in pinot broker URL: https://github.com/apache/incubator-pinot/pull/3568#issuecomment-443390975 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=h1) Report > Merging [#3568](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/335e967f46302471eaef3b76db1600b41b35fa9b?src=pr&el=desc) will **increase** coverage by `21.41%`. > The diff coverage is `81.42%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3568 +/- ## ============================================= + Coverage 45.75% 67.16% +21.41% - Complexity 0 4 +4 ============================================= Files 1027 1030 +3 Lines 50789 50865 +76 Branches 7089 7096 +7 ============================================= + Hits 23236 34163 +10927 + Misses 25617 14357 -11260 - Partials 1936 2345 +409 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `39.58% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQ29ubmVjdGlvblBvb2xCcm9rZXJSZXF1ZXN0SGFuZGxlci5qYXZh) | `88.19% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/common/utils/request/RequestUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvcmVxdWVzdC9SZXF1ZXN0VXRpbHMuamF2YQ==) | `97.01% <100%> (+28.01%)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../broker/requesthandler/BrokerRequestOptimizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQnJva2VyUmVxdWVzdE9wdGltaXplci5qYXZh) | `68% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pache/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0Jyb2tlclNlcnZlckJ1aWxkZXIuamF2YQ==) | `91.66% <100%> (+0.14%)` | `0 <0> (ø)` | :arrow_down: | | [.../BrokerResourceOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclJlc291cmNlT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `50.81% <100%> (+1.66%)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/requesthandler/TableSchemaCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvVGFibGVTY2hlbWFDYWNoZS5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `88.63% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh) | `72.64% <100%> (+9.17%)` | `0 <0> (ø)` | :arrow_down: | | ... and [533 more](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=footer). Last update [335e967...ae03d65](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
