mcvsubbu commented on a change in pull request #3749: Fix
SegmentStatusCheckerIntegrationTest setup timings
URL: https://github.com/apache/incubator-pinot/pull/3749#discussion_r251537282
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/RealtimeSegmentRelocator.java
##########
@@ -66,17 +69,25 @@ protected void initTask() {
@Override
protected void preprocess() {
-
+ super.preprocess();
Review comment:
Instead of relying on every task calling super methods for preprocess and
postprocess, will it not be better to introduce a different abstract method
(say, preProcessInternal, postProcessInternal) and have the tasks implement
those?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
