codecov-io commented on issue #3758: Better handle NPE from getting instance config URL: https://github.com/apache/incubator-pinot/pull/3758#issuecomment-458375433 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=h1) Report > Merging [#3758](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/8f239f5325d2549aac44fdfabec4f1676bdc9008?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3758 +/- ## =========================================== + Coverage 67.22% 67.32% +0.1% Complexity 4 4 =========================================== Files 1027 1028 +1 Lines 50804 50814 +10 Branches 7088 7089 +1 =========================================== + Hits 34152 34213 +61 + Misses 14322 14267 -55 - Partials 2330 2334 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../pinot/controller/api/upload/SegmentValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1NlZ21lbnRWYWxpZGF0b3IuamF2YQ==) | `60% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/controller/validation/StorageQuotaChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1N0b3JhZ2VRdW90YUNoZWNrZXIuamF2YQ==) | `73.33% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/pinot/controller/util/TableSizeReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci91dGlsL1RhYmxlU2l6ZVJlYWRlci5qYXZh) | `96.07% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...not/controller/api/resources/PqlQueryResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1BxbFF1ZXJ5UmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...er/api/resources/PinotInstanceRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90SW5zdGFuY2VSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `65.95% <100%> (+0.74%)` | `0 <0> (ø)` | :arrow_down: | | [...ot/common/exception/InstanceNotFoundException.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL0luc3RhbmNlTm90Rm91bmRFeGNlcHRpb24uamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `60.65% <100%> (+0.22%)` | `0 <0> (ø)` | :arrow_down: | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `65.45% <0%> (-7.28%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvTG9uZ09uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRmxvYXRPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `87.27% <0%> (-5.46%)` | `0% <0%> (ø)` | | | ... and [26 more](https://codecov.io/gh/apache/incubator-pinot/pull/3758/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=footer). Last update [8f239f5...a61732a](https://codecov.io/gh/apache/incubator-pinot/pull/3758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
