snleee commented on a change in pull request #3770: Remove unnecessary init
from crypter
URL: https://github.com/apache/incubator-pinot/pull/3770#discussion_r252556172
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentFetcherAndLoader.java
##########
@@ -200,7 +200,6 @@ private String downloadSegmentToLocal(@Nonnull String uri,
PinotCrypter crypter,
SegmentFetcherFactory.getInstance().getSegmentFetcherBasedOnURI(uri).fetchSegmentToLocal(uri,
tempDownloadFile);
if (crypter != null) {
// TODO: We should not need to initialize crypter each time, instead
Factory should have an initialized version ready.
Review comment:
Is this comment still valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
