akshayrai commented on a change in pull request #3767: [TE] detection - yaml
translation/migration changes
URL: https://github.com/apache/incubator-pinot/pull/3767#discussion_r252797509
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
##########
@@ -158,10 +159,23 @@
private static final String PROP_MERGER = "merger";
private static final String PROP_TIMEZONE = "timezone";
private static final String PROP_NAME = "name";
+ private static final String DEFAULT_TIMEZONE = "America/Los_Angeles";
private static final String DEFAULT_BASELINE_PROVIDER_YAML_TYPE =
"RULE_BASELINE";
private static final DetectionRegistry DETECTION_REGISTRY =
DetectionRegistry.getInstance();
- private static final Map<String, String> DETECTOR_TO_BASELINE =
ImmutableMap.of("ALGORITHM", "ALGORITHM_BASELINE");
+ static {
+ // do not tune for alerts migrated from legacy anomaly function.
+
DetectionRegistry.registerComponent("com.linkedin.thirdeye.detection.components.AdLibAlertFilter",
+ "MIGRATED_ALGORITHM_FILTER");
Review comment:
1. Why should tuning be disabled for migrated functions? Can you provide
some context?
2. Do we really need a new MIGRATED tag? When will we update them later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
