akshayrai commented on a change in pull request #3782: [TE] Clean up the log
messages and exceptions
URL: https://github.com/apache/incubator-pinot/pull/3782#discussion_r253233128
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipeline.java
##########
@@ -61,17 +61,15 @@
protected final long startTime;
protected final long endTime;
- protected DetectionPipeline(DataProvider provider, DetectionConfigDTO
config, long startTime, long endTime)
- {
+ protected DetectionPipeline(DataProvider provider, DetectionConfigDTO
config, long startTime, long endTime) {
this.provider = provider;
this.config = config;
this.startTime = startTime;
this.endTime = endTime;
try {
this.initComponents();
} catch (Exception e) {
- LOG.error("Initialize components failed", e);
Review comment:
Usually logging and throwing is an anti-pattern. This exception is caught
later and logged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
