snleee commented on a change in pull request #3772: Update pom files for
preparing Apache release
URL: https://github.com/apache/incubator-pinot/pull/3772#discussion_r253258203
##########
File path: pinot-distribution/pinot-assembly.xml
##########
@@ -48,13 +48,28 @@
</includes>
</dependencySet>
</dependencySets>
+
+ <files>
+ <!-- Rename LICENSE-binary, NOTICE-binary to LICENSE, NOTICE and include
them to a distribution tarbell -->
+ <file>
+ <source>${pinot.root}/LICENSE-binary</source>
+ <destName>LICENSE</destName>
+ </file>
+ <file>
+ <source>${pinot.root}/NOTICE-binary</source>
+ <destName>NOTICE</destName>
+ </file>
+ <!-- Include DISCLAIMER -->
+ <file>
+ <source>${pinot.root}/DISCLAIMER</source>
+ </file>
+ </files>
<fileSets>
+ <!-- Rename liscenses-binary directory to licenses and include it to a
distribution tarbell -->
Review comment:
Thanks for the catch. I will resolve it with a follow-up pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]