mcvsubbu commented on a change in pull request #3788: Adding explicit message
to alert users to empty input files during segment generation
URL: https://github.com/apache/incubator-pinot/pull/3788#discussion_r253595318
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentIndexCreationDriverImpl.java
##########
@@ -119,7 +119,7 @@ public void init(SegmentGeneratorConfig config,
SegmentCreationDataSource dataSo
this.config = config;
this.createStarTree = config.isEnableStarTreeIndex();
recordReader = dataSource.getRecordReader();
- Preconditions.checkState(recordReader.hasNext(), "No record in data
source");
+ Preconditions.checkState(recordReader.hasNext(), "No records found: You
must have at least one record in each of your input files");
Review comment:
Alternatively, check in hadoop job before we call this method, and error-log
+ exception like i described before. Then the pre-condition check here is
totally valid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
