aaronucsd commented on a change in pull request #3787: [TE] frontend -
harleyjj/yaml-editor - implements simple graph for pr…
URL: https://github.com/apache/incubator-pinot/pull/3787#discussion_r253601268
##########
File path:
thirdeye/thirdeye-frontend/app/pods/components/yaml-editor/component.js
##########
@@ -233,10 +487,12 @@ export default Component.extend({
actions: {
/**
- * triggered by preview dropdown
+ * triggered by preview button
*/
- showPreview() {
- this.toggleProperty('toggleCollapsed');
+ getPreview() {
+ set(this, 'isLoading', true);
Review comment:
same here. setProperties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
