akshayrai commented on a change in pull request #3790: [TE] yaml - onboarding
tasks
URL: https://github.com/apache/incubator-pinot/pull/3790#discussion_r254366707
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -225,6 +267,7 @@ public Response createYamlAlert(@ApiParam(value = "a json
contains both notific
}
long alertId = Long.parseLong(((Map<String, String>)
response.getEntity()).get("detectionAlertConfigId"));
+ createYamlOnboardingTask(detectionConfigId, startTime, endTime);
Review comment:
Enclose in try-catch. If exception is thrown, revert changes and display
message 'failed to setup the onboarding job`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
