Hi Felix, I retried to build NOTICE file and get the same result for concatenated NOTICE. I think that those are the part of old glassfish.jersey libraries. If you confirm, I will go ahead of merging the pr.
Best, Seunghyun On Wed, Feb 6, 2019 at 10:08 AM Seunghyun Lee <[email protected]> wrote: > I rebuilt NOTICE-binary file using the same approach and those were cut > out. I will check that one more time and get back to you. > > Best, > Seunghyun > > On Wed, Feb 6, 2019 at 12:46 AM Felix Cheung <[email protected]> > wrote: > >> For #1 LG generally. What happened to the whole chunk of Apache ones >> like Apache >> Commons Net? >> >> #2 LGTM >> >> On Tue, Feb 5, 2019 at 9:59 PM Seunghyun Lee <[email protected]> wrote: >> >> > Hi Felix, >> > >> > Before we cut the release candidate, I have some remaining checks from >> you. >> > >> > 1. Can you double check on the update for LICENSE-binary/NOTICE-binary >> due >> > to jersery version upgrade? (A lot of glassfish projects have been moved >> > from CDDL to EPL 2.0.) >> > https://github.com/apache/incubator-pinot/pull/3791 >> > >> > 2. Can you also comment on my reply on the issue with removing >> "*-binary" >> > files/directories? (refer pinot-assembly.xml file) >> > https://github.com/apache/incubator-pinot/pull/3772 >> > >> > I really appreciate your help. >> > >> > Best, >> > Seunghyun >> > >> >
