akshayrai commented on a change in pull request #3810: [TE] detection - caching
& configure time granularity
URL: https://github.com/apache/incubator-pinot/pull/3810#discussion_r255273968
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionConfigTranslator.java
##########
@@ -108,6 +108,5 @@ public DetectionConfigDTO generateDetectionConfig() {
*/
protected void validateYAML(Map<String, Object> yamlConfig) {
Preconditions.checkArgument(yamlConfig.containsKey(PROP_NAME), "Property
missing " + PROP_NAME);
- Preconditions.checkArgument(yamlConfig.containsKey(PROP_DESC_NAME),
"Property missing " + PROP_DESC_NAME);
Review comment:
I think description should be made compulsory to improve the overall
experience of the alert recipients. We can discuss this later. Not urgent!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
