jackjlli commented on a change in pull request #3568: Add guava cache to cache
table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r255385156
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -197,8 +202,9 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
}
// Validate the request
+ FilterQueryTree[] filterQueryTree = new FilterQueryTree[1];
Review comment:
We need an instance of FilterQueryTree to be returned if it's been
calculated. And simply returning this instance out of the method
`validateRequest` looks unreasonable. Thus, I use an array to return the
instance. Another way to handle that is to add a private variable of
`FilterQueryTree` in requestParams.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
