snleee commented on a change in pull request #3813: Refactor Hadoop Jobs
URL: https://github.com/apache/incubator-pinot/pull/3813#discussion_r255650955
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HadoopSegmentBuildPushOfflineClusterIntegrationTest.java
##########
@@ -155,13 +155,13 @@ private void generateAndPushSegmentsFromHadoop()
properties.setProperty(JobConfigConstants.PUSH_TO_PORT,
getDefaultControllerConfiguration().getControllerPort());
// Run segment creation job
- SegmentCreationJob creationJob = new
SegmentCreationJob("TestSegmentCreation", properties);
+ SegmentCreationJob creationJob = new SegmentCreationJob(properties);
Review comment:
I think that it's better to expose `JobName` to be configurable. It's fine
to include that config within `properties` and read it back along with other
config instead of having it as an input variable for constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
