akshayrai commented on a change in pull request #3816: [TE] yaml - error
messages
URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r255756101
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java
##########
@@ -142,7 +142,7 @@ public Response getSubscriptionGroups(@ApiParam("the
detection config id") @Path
List<DetectionAlertConfigDTO> detectionAlertConfigDTOs =
this.detectionAlertConfigDAO.findAll();
Set<DetectionAlertConfigDTO> subscriptionGroupAlertDTOs = new HashSet<>();
for (DetectionAlertConfigDTO alertConfigDTO : detectionAlertConfigDTOs){
- if (alertConfigDTO.getVectorClocks().containsKey(id)){
Review comment:
Why check both? Aren't the vector clocks and the detectionConfigIds list
always in sync?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
