jackjlli commented on a change in pull request #3819: Refactor periodic task
URL: https://github.com/apache/incubator-pinot/pull/3819#discussion_r255820427
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/relocation/RealtimeSegmentRelocator.java
##########
@@ -62,32 +61,13 @@ public RealtimeSegmentRelocator(PinotHelixResourceManager
pinotHelixResourceMana
config.getPeriodicTaskInitialDelayInSeconds(),
pinotHelixResourceManager, controllerMetrics);
}
- @Override
- protected void initTask() {
-
- }
-
- @Override
- protected void preprocess() {
- }
-
@Override
protected void processTable(String tableNameWithType) {
- CommonConstants.Helix.TableType tableType =
TableNameBuilder.getTableTypeFromTableName(tableNameWithType);
- if (tableType == CommonConstants.Helix.TableType.REALTIME) {
+ if (TableNameBuilder.REALTIME.tableHasTypeSuffix(tableNameWithType)) {
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
