Jackie-Jiang commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462970857 @sunithabeeram The race condition between start() and stop(), and is addressed by adding synchronization. As for the leader and non-leader change, ControllerPeriodicTaskTest covers the test of start() and stop(), which are called in ControllerPeriodicTaskScheduler onBecomingLeader() and onBecomingNonLeader() (implementing LeadershipChangeSubscriber).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
