mcvsubbu commented on a change in pull request #3836: Clarify all methods in
PinotFS
URL: https://github.com/apache/incubator-pinot/pull/3836#discussion_r256660305
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java
##########
@@ -219,12 +219,12 @@ public void removeAgedDeletedSegments(int
retentionInDays) {
PinotFS pinotFS = PinotFSFactory.create(dataDirURI.getScheme());
// Check that the directory for deleted segments exists
- if (!pinotFS.isDirectory(deletedDirURI)) {
- LOGGER.warn("Deleted segment directory {} does not exist or it is not
directory.", deletedDirURI.toString());
- return;
- }
-
try {
+ if (!pinotFS.isDirectory(deletedDirURI)) {
Review comment:
move the comment inside
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
