akshayrai commented on a change in pull request #3830: [TE] Presto Connector
backend and front end
URL: https://github.com/apache/incubator-pinot/pull/3830#discussion_r256930104
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/presto/PrestoDataset.java
##########
@@ -0,0 +1,61 @@
+package org.apache.pinot.thirdeye.datasource.presto;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.thirdeye.constant.MetricAggFunction;
+
+
+public class PrestoDataset {
+
+
+ @JsonProperty
+ private String tableName;
+ @JsonProperty
+ private String timeColumn;
+ @JsonProperty
+ private List<String> dimensions;
+ @JsonProperty
+ private Map<String, MetricAggFunction> metrics;
+ @JsonProperty
+ private String granularity = "1hour";
+ @JsonProperty
+ private String timezone = "America/Los_Angeles";
Review comment:
I'd use UTC (TimeSpec.DEFAULT_TIMEZONE) unless it is on purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]