+1 1. Checked that the bundles contains "incubating" 2. Verified the signature and hash 3. Verified that the release source matches with the code from Github 4. Checked that the source can be compiled (used RHEL 7 linux) 5. Ran quick starter script to check the basic functionality
Suggestion: 1. You mentioned that the artifact is signed with key *44BA03AD164D961B. *Actually, this is my key. You need to change it to yours, which is *164D961B.* 2. Let's actually add header information in https://dist.apache.org/repos/dist/release/incubator/pinot/KEYS If we included the header information, we can easily check if key id mentioned in the mail is valid. We cannot know if your key id (*164D961B*) is valid or not by looking at KEYS file since we only added your actual key content. e.g. """ pub rsa2048 2019-02-01 [SC] [expires: 2021-01-31] FD534854D542FD474278B85344BA03AD164D961B uid [ultimate] Seunghyun Lee <[email protected]> sig 3 44BA03AD164D961B 2019-02-01 Seunghyun Lee <[email protected]> sub rsa2048 2019-02-01 [E] [expires: 2021-01-31] sig 44BA03AD164D961B 2019-02-01 Seunghyun Lee <[email protected]> """ On Wed, Nov 13, 2019 at 9:34 AM Mayank Shrivastava <[email protected]> wrote: > +1 > ________________________________ > From: Subbu Subramaniam <[email protected]> > Sent: Tuesday, November 12, 2019 1:41 PM > To: [email protected] <[email protected]> > Subject: [VOTE] Apache Pinot (incubating) 0.2.0 RC0 > > Hi Pinot Community, > > This is a call for vote to the release Apache Pinot (incubating) version > 0.2.0. > > The release candidate: > https://dist.apache.org/repos/dist/dev/incubator/pinot/apache-pinot-incubating-0.2.0-rc0 > > Git tag for this > release:https://github.com/apache/incubator-pinot/tree/release-0.2.0-rc0 > Git hash for this release:f8e1980c4160ac7fd2686d9edefab9ac0a825c5b > > The artifacts have been signed with key: 44BA03AD164D961B, which can be > found in the following KEYS > file.https://dist.apache.org/repos/dist/release/incubator/pinot/KEYS > > Release notes: > https://github.com/apache/incubator-pinot/releases/tag/release-0.2.0-rc0 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachepinot-1003 > > Documentation on verifying a release > candidate: > https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate > > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > Please vote accordingly, > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > Apache Pinot (incubating) team >
