Thanks, Kishore. This simplifies a lot of things for us. Jia, I would suggest moving the request optimizer to core in a separate PR for ease of review.
On Mon, Aug 3, 2020 at 2:22 PM kishore g <[email protected]> wrote: > It's ok to move the request optimizer to core. We have to clean up the > core and common anyway and we can handle it when we get there > > On Mon, Aug 3, 2020 at 2:17 PM Jia Guo <[email protected]> > wrote: > >> Hi Pinot Devs, >> >> >> >> This is Jia from Pinot team @ LinkedIn. Currently @Siddharth >> Teotia <[email protected]>, @Dino Occhialini >> <[email protected]>, and I are integrating a config >> recommendation engine within LI. For cleaner interface and better user >> experience, it is good to have a rest endpoint on controller; and >> therefore the engine should also resides in controller. To achieve this, we >> are proposing to move its dependencies, request optimizer and parser >> factory, from broker to core. We have explored other options as -- (1) >> moving engine to broker, but logically having this API on broker does not >> make sense and will be hard to invoke, (2) moving dependencies to common, >> will require more dependencies (e.g. part of query context) to be moved >> from core to common to avoid cycle, which is not clean; and so finally >> moving optimizer to core is a viable solution. >> >> Please feel free to give us feedback! Thanks! >> >> >> >> >> >> >> > -- *Best Regards,* *SIDDHARTH TEOTIA* *2008C6PS540G* *BITS PILANI- GOA CAMPUS* *+91 87911 75932*
