Thanks for bringing this up, Rong. Before Pinot 0.3.0. we used antlr to define PQL syntax and build the query parser. The biggest limitation here is the syntax extensibility with new functions and some syntax and query behavior is different from SQL, e.g. GROUP BY column1 TOP 10.
From Pinot 0.3.0, we introduced Calcite SQL engine and deprecated PQL, the PQL query endpoint is still maintained. After Pinot 0.9.0 release, we will remove all the code reference to PQL. Best, Xiang > On Sep 14, 2021, at 9:50 AM, Rong Rong <walter...@gmail.com> wrote: > > +1 to deprecate PQL fully. > > Just to clarify: > > On Tue, Sep 14, 2021 at 1:51 AM Xiang Fu <xiangfu.1...@gmail.com > <mailto:xiangfu.1...@gmail.com>> wrote: > TL;DR, Pinot will remove PQL query endpoint and response format > <https://docs.pinot.apache.org/users/api/querying-pinot-using-standard-sql/response-format#pql-response> > after 0.9.0 release, only SQL endpoint > <https://docs.pinot.apache.org/users/api/querying-pinot-using-standard-sql/response-format#standard-sql-response> > is supported afterward. > > >> does this mean we still support SQL endpoint? It seems to contradict with > >> the wording below: > > So we decide to remove the PQL query path and endpoint. If you are still on > the PQL query path, please migrate to SQL endpoint: > https://docs.pinot.apache.org/users/user-guide-query/querying-pinot > <https://docs.pinot.apache.org/users/user-guide-query/querying-pinot> > > > 2. Apache Pinot master branch will remove PQL support once the 0.9.0 release > is cut, and no PQL support from the 0.10.0 release. > > >> Shall we keep PQL codepath and annotate with @deprecated, then officially > >> remove it on 0.10.0? makes it easy if we decided to do a point release. > > > -- > Rong
