Overall, it seems good to me. +1 (non-binding)
Thanks On Thu, Aug 1, 2024 at 2:07 PM robert zych <robert.z...@gmail.com> wrote: > Hey Ankit, > > I followed the steps in the documentation and didn't spot any issues other > than the one Yash mentioned. > > +1 (non-binding) > > Cheers, > Robert > > On Wed, Jul 31, 2024 at 11:54 PM Yash Mayya <yash.ma...@gmail.com> wrote: > >> Hi Ankit, >> >> Thanks for running the release! I performed the following verifications: >> >> - Verified the signatures >> - Verified the checksums >> - Verified that the LICENSE and NOTICE files exist in the source and >> binary distributions >> - Verified the git commit hash / tag >> - Verified that the source distribution compiles with JDK 17 >> - Verified that quickstarts and some sample v2 engine queries work on >> both the source and binary distributions >> >> One minor issue I noticed though is that quickstarts when run from the >> compiled source distribution can't load some tables due to the following >> dependency error: "java.lang.NoClassDefFoundError: >> org/apache/hadoop/shaded/com/ctc/wstx/io/InputBootstrapper". This was fixed >> in https://github.com/apache/pinot/pull/13548; do you think we could >> cherry pick this fix to the release-1.2.0-rc branch? I'm not sure that this >> warrants building a new RC though. >> >> +1 (non-binding) >> >> Thanks, >> Yash >> >> On Thu, Aug 1, 2024 at 2:19 AM Ankit Sultana <ankitsult...@gmail.com> >> wrote: >> >>> Hi Pinot Community, >>> >>> This is a call for a vote to release *Apache Pinot 1.2.0*. >>> >>> The release candidate: >>> https://dist.apache.org/repos/dist/dev/pinot/apache-pinot-1.2.0-rc0/ >>> >>> Git tag for this release: >>> https://github.com/apache/pinot/tree/release-1.2.0-rc0 >>> >>> Git hash for this release: 30c15985bd5598f762068397f19bb9ebf5b28e07 >>> >>> The artifacts have been signed with the key: 3EF8710DD8FB46E7, which can >>> be found in the KEYS file: dist/release/pinot/KEYS >>> <https://dist.apache.org/repos/dist/release/pinot/KEYS#:~:text=org%3E%0Asig%203-,3EF8710DD8FB46E7,-2024%2D07%2D08> >>> >>> Release Notes: >>> https://github.com/apache/pinot/releases/tag/release-1.2.0-rc0 >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachepinot-1062/ >>> >>> Documentation on verifying a release candidate: >>> https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate >>> >>> The vote will be open for at least 72 hours or until a necessary number >>> of >>> votes is reached. >>> >>> Please vote accordingly, >>> >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> Thanks, >>> Apache Pinot Team >>> >>
