+1 (binding) Verified on my mac with java 22 as well.
Best Regards, Xiang On Mon, Aug 12, 2024 at 7:25 AM Yash Mayya <yash.ma...@gmail.com> wrote: > > Hi Ankit, > > Thanks for running the release! I performed the following verifications: > > Verified the signatures > Verified the checksums > Verified that the LICENSE and NOTICE files exist in the source and binary > distributions > Verified the git commit hash / tag > Verified that the source distribution compiles with JDK 17 > Verified that quickstarts and some sample v2 engine queries work on both the > source and binary distributions > > I also validated that the RC no longer has the quickstart dependency issue > from RC0 and that the bugfix for filtered aggregations with ordering is > present. > > +1 (non-binding) > > Thanks, > Yash > > On Sun, Aug 11, 2024 at 7:12 AM Ankit Sultana <ankitsult...@gmail.com> wrote: >> >> Hi Pinot Community, >> >> This is a call for a vote to release Apache Pinot 1.2.0. >> >> The release candidate: >> https://dist.apache.org/repos/dist/dev/pinot/apache-pinot-1.2.0-rc2/ >> >> Git tag for this release: >> https://github.com/apache/pinot/tree/release-1.2.0-rc2 >> >> Git hash for this release: cc33ac502a02e2fe830fe21e556234ee99351a7a >> >> The artifacts have been signed with the key: 3EF8710DD8FB46E7, which can be >> found in the KEYS file: dist/release/pinot/KEYS >> >> Release Notes: https://github.com/apache/pinot/releases/tag/release-1.2.0-rc2 >> >> Staging repository: >> https://repository.apache.org/content/repositories/orgapachepinot-1064/ >> >> Documentation on verifying a release candidate: >> https://cwiki.apache.org/confluence/display/PINOT/Validating+a+release+candidate >> >> The vote will be open for at least 72 hours or until a necessary number of >> votes is reached. Please vote accordingly. >> >> Difference between RC2 and RC1 >> >> Around the time we raised the vote for RC1, there was a bug reported in >> Filtered Aggregates that could lead to wrong query results. This was fixed >> by Jackie and the commit has been cherry-picked in RC2. In other words, >> there's only a single commit difference between RC2 and RC1 which is listed >> below: >> >> * Fix filtered aggregate with ordering >> https://github.com/apache/pinot/commit/6943c0c692a5bc2512f96da5657d6d830ed050c8 >> >> Difference between RC1 and RC0 >> >> RC1 has the cherry-pick fix for the issue called out in the previous voting. >> Additionally, on recomputing the LICENSE-binary file changes, I found minor >> errors and there's another cherry-pick to correct them. The new cherry-picks >> on top of RC0 are listed below: >> >> * Add hadoop-client-runtime dependency to fix quickstart >> NoClassDefFoundError issue >> https://github.com/apache/pinot/commit/81cf64f26aa412781c7b77be8107ae60795978f5 >> * Minor LICENSE-binary Correction for 1.2.0 Release >> https://github.com/apache/pinot/commit/ad284a6d91036152139d7aacb463aed28653aa57 >> >> [ ] +1 approve >> [ ] +0 no opinion >> [ ] -1 disapprove with the reason >> >> Thanks, >> Apache Pinot Team --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org For additional commands, e-mail: dev-h...@pinot.apache.org
