GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/10
[trivial] Minor code fixes
Some minor changes made while browsing the code. including
- closing the file stream to avoid resource leakage in Responder.java
- avoiding boxing/unboxing a byte value
- equivalent code in few lines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit 972ec6ac712f6e369bdf83a5f5a5137ce54b668a
Author: Tim Ellison <[email protected]>
Date: 2016-07-14T09:09:28Z
Ignore logs created at runtime.
commit 0625bc5516fa947d7b7136ac8a50783a0df0ae3e
Author: Tim Ellison <[email protected]>
Date: 2016-07-18T11:04:07Z
Merge branch 'master' of https://github.com/apache/incubator-pirk
Conflicts:
.gitignore
commit 9943702dd53a6e9eb28ffef69c4a97ac864be7fb
Author: Tim Ellison <[email protected]>
Date: 2016-07-19T07:25:18Z
Merge branch 'master' of https://github.com/apache/incubator-pirk
commit e408151cd084259104a6c49014d18522d06c2d75
Author: Tim Ellison <[email protected]>
Date: 2016-07-19T07:40:15Z
Close the file stream to avoid resource leakage.
commit 2ca0a62fc4f02e96afd2cf56f9cd84e0e8ab150f
Author: Tim Ellison <[email protected]>
Date: 2016-07-19T07:40:42Z
Avoid boxing and immediate unboxing of Byte.
commit 6fa8e89aaf0745a4e7720b318dc30bcee3f60e24
Author: Tim Ellison <[email protected]>
Date: 2016-07-19T07:41:34Z
Reduce some code verbiage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
