GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/13
[trivial] Enhancements to build XML and Paillier class.
1) Updated the POM to consider Pirk's files as UTF-8 encoded, and avoid the
warning during build.
2) Changed Paillier from the copy constructor to clone(), which is
idiomatic to copying Java instances.
3) Modest reordering of while condition, to avoid lengthy mod() calls when
later, simpler checks would fail.
4) Consistency in returning expression results from methods, rather than
storing and returning a local.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk trivial
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit 4dc36feee82d6e36a0b7e64127dca5444dd59c78
Author: Tim Ellison <[email protected]>
Date: 2016-07-20T08:55:38Z
Consider resources as stored in UTF-8 format.
commit ef0a2cbd94c54679a921e2a1d39334b8fba31bfc
Author: Tim Ellison <[email protected]>
Date: 2016-07-20T09:33:47Z
Implement idiomatic clone() in preference to copy constructor.
- Change copy constructor to clone().
- Move terms to left of logic expression to take advantage of lazy
evaluation.
- Allow methods to return results directly.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
