Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/18
Very nice - much cleaner.
One very minor thing that you may want to go ahead and change in
ExpTableMapper:
`query = new
HadoopFileSystemStore(FileSystem.newInstance(ctx.getConfiguration())).recall(queryDir,
Query.class);`
to
`query = new HadoopFileSystemStore(fs).recall(queryDir, Query.class);`
as the FileSystem fs has already been grabbed a couple of lines above.
Otherwise, we will need to make sure that custom StorageServices and
SerializationServices have corresponding tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
