The code may have to go thru another round of cleanup, for eg: In Java7> List<String> list = new ArrayList<>(); In Java 8> List<String> list = new ArrayList();
Also, have been cautioned by the Beam folks about using Java 8 lambdas. Projects like Flink and others have a separate module for Java 8 lambda implementations. Hence, I wasn't sure if we wanted to change <javac.target> to 1.8. thoughts? On Sat, Jul 23, 2016 at 6:49 PM, Tim Ellison <[email protected]> wrote: > On 23/07/16 23:03, Suneel Marthi wrote: > > yeah, wasn't sure if we wanted to retain some Java 7 compatibility. > > > > Maybe retain <maven.compiler.target> as 1.7 still. > > What do you mean? Upgrade and enforce Java 8, but only use Java 7 > features? > > Regards, > Tim > > > > On Sat, Jul 23, 2016 at 6:00 PM, Tim Ellison <[email protected]> > wrote: > > > >> On 23/07/16 03:54, smarthi wrote: > >>> Github user smarthi commented on the issue: > >>> > >>> https://github.com/apache/incubator-pirk/pull/19 > >>> > >>> This is good to merge now. It enforces Java 8 and Maven 3.3.9 as > >> also RAT checks for license headers. > >> > >> Looks like there are still some vestiges of Java 7 in the pom.xml(s) > >> <properties>. Presumably these should be fixed under this JIRA too. > >> > >> <properties> > >> <maven.compiler.source>1.7</maven.compiler.source> > >> <maven.compiler.target>1.7</maven.compiler.target> > >> <javac.target>1.7</javac.target> > >> </properties> > >> > >> Regards, > >> Tim > >> > > >
