GitHub user tellison opened a pull request:

    https://github.com/apache/incubator-pirk/pull/25

    [PIRK-25] Additional comments and tidy-up.

    Enhancement to merged commit for PIRK-25, adding some comments and using 
try-with-resources.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tellison/incubator-pirk serialization

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/25.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #25
    
----
commit aef6aea88896f808c578e3660785a9b8483e375d
Author: Tim Ellison <[email protected]>
Date:   2016-07-22T14:40:12Z

    Serialization and storage changes to Querier, Query, and Response.
    
     - Introduce serialization services that can flatten objects into a
    variety of different formats.  Currently just reusing the Java
    serialization code until the project is ready to adopt other
    serializers.
     
     - Introduce storage services that can store objects and retrieve them.
    Currently just reusing the local file system and HDFS.  The storage
    service uses one of the serialization services to flatten the objects.
     
     - Remove code from Querier, Query, and Response that was serializing
    and storing each of them; and update the callers to use the storage
    services.

commit 77baa948ea2092cf1ce9de8e8be380aef2331d31
Author: Tim Ellison <[email protected]>
Date:   2016-07-23T21:02:19Z

    Merge branch 'master' of https://github.com/apache/incubator-pirk into
    serialization
    
    Conflicts:
        src/main/java/org/apache/pirk/querier/wideskies/Querier.java
        src/main/java/org/apache/pirk/querier/wideskies/QuerierDriver.java
        src/main/java/org/apache/pirk/query/wideskies/Query.java
        
src/main/java/org/apache/pirk/responder/wideskies/mapreduce/ExpTableMapper.java
        
src/main/java/org/apache/pirk/responder/wideskies/mapreduce/FinalResponseReducer.java
        
src/main/java/org/apache/pirk/responder/wideskies/mapreduce/HashSelectorsAndPartitionDataMapper.java
        
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeExpLookupTable.java
        
src/main/java/org/apache/pirk/responder/wideskies/spark/ComputeResponse.java
        src/main/java/org/apache/pirk/response/wideskies/Response.java
        src/main/java/org/apache/pirk/test/utils/StandaloneQuery.java

commit dd13367ea62c214b7fb6c11ee415bb8ccbe2a53c
Author: Tim Ellison <[email protected]>
Date:   2016-07-23T21:37:26Z

    Add comments and use try-with-resources.
    
     - remove placeholder for JSON serializer.  Will be reintroduced when a
    JSON serializer is available in Pirk.

commit ed2c51f83cd509da7f78552503cc920d66577fc5
Author: Tim Ellison <[email protected]>
Date:   2016-07-24T13:15:39Z

    Merge branch 'master' of https://github.com/apache/incubator-pirk into
    serialization
    
    Conflicts:
        
src/main/java/org/apache/pirk/responder/wideskies/standalone/Responder.java
        src/main/java/org/apache/pirk/serialization/HadoopFileSystemStore.java
        src/main/java/org/apache/pirk/serialization/JavaSerializer.java
        src/main/java/org/apache/pirk/serialization/LocalFileSystemStore.java
        src/main/java/org/apache/pirk/serialization/Storable.java
        src/main/java/org/apache/pirk/serialization/StorageService.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to