On 29/07/16 03:55, Apache Jenkins Server wrote:
> See <https://builds.apache.org/job/pirk/org.apache.pirk$pirk/13/changes>
Travis liked this commit ok, but Jenkins failed with:
java.io.IOException: No such file or directory
at java.io.UnixFileSystem.createFileExclusively(Native Method)
at java.io.File.createTempFile(File.java:1879)
at java.io.File.createTempFile(File.java:1923)
at
org.apache.pirk.test.utils.TestUtils.writeToTmpFile(TestUtils.java:300)
at org.apache.pirk.test.utils.Inputs.createPIRStopList(Inputs.java:411)
at
test.wideskies.standalone.StandaloneTest.<init>(StandaloneTest.java:55)
== Observation 1 ==
Looks like there was a change to
org.apache.pirk.test.utils.Inputs#createPIRStopList(FileSystem,
boolean):line 411
that means the standalone test stop list file name property is now
DistributedTestDriver.PIR_STOPLIST_FILE
(a.k.a. "test.pir.stopListFile"), whereas before the commit it was
"pir.stopListFile".
Was that intentional? I'm suspicious because StandaloneTest:line 54 is
still setting "pir.stopListFile"
Also, is it correct that the hdfs=true case falls through and creates
the local file stop list too?
I've opened PR#30 to put the local property name back to "pir.stopListFile".
== Observation 2 ==
The new code in SystemConfiguration#loadPropsFromDir(String) to load all
properties from a directory can cause inconsistent behavior.
The final set of properties will depend upon the order of the files
loaded, and that is not guaranteed, i.e. any property set in a loaded
file will be overwritten by the same property set in a file that is
loaded later.
For example, in this run:
INFO [main] 2016-07-29 02:49:19,345 (SystemConfiguration.java:202) -
Loading file 'pirk.properties'
INFO [main] 2016-07-29 02:49:19,362 (SystemConfiguration.java:202) -
Loading file 'querier.properties'
INFO [main] 2016-07-29 02:49:19,362 (SystemConfiguration.java:202) -
Loading file 'responder.properties'
any pirk.properties configuration would be overwritten by the same
property given in querier.properties.
While in this case the files were loaded in alphabetical order, there is
no guarantee that the directory list, hence the properties had better be
disjoint sets.
Regards,
Tim
