GitHub user jkovba opened a pull request:

    https://github.com/apache/incubator-pirk/pull/43

    PIRK-29

    Implemented a check to ensure the queryID (formerly named queryName) in the 
Querier matches the queryID in the Response object.
    
    Added a timestamp to the queryID for uniqueness.
    
    Renamed some fields/methods for uniformity.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkovba/incubator-pirk PIRK-29

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/43.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #43
    
----
commit 22e11ab4701a79ed8e6095f311b120cd11b76413
Author: jkovba <[email protected]>
Date:   2016-07-29T22:48:10Z

    Renamed getPirWatchlist() to getQueryInfo() in Querier.java to match the
    method name in Response.java

commit 0ee6a93acc199ab9b143f541b4d077b2a3546eaf
Author: jkovba <[email protected]>
Date:   2016-07-30T11:11:31Z

    Changed all occurrences of queryName to queryID in Querier.java

commit c7210071e991828b5dfd41511e60f87242eef409
Author: jkovba <[email protected]>
Date:   2016-07-30T11:14:53Z

    Changed all occurrences of queryName to queryID in QuerierDriver.java
    and QuerierDriveCLI.java

commit bc1b2809e948290e970c63eec49e3fcabe69891a
Author: jkovba <[email protected]>
Date:   2016-07-30T12:00:24Z

    Added check to ensure queryID in Querier file matches the one in the
    Response

commit 417c492dc79c431e079baffb9a4b1178fe28e31e
Author: jkovba <[email protected]>
Date:   2016-07-30T12:12:51Z

    Added unique date/time string to QueryID field in QuerierDriverCLI.java

commit a7435b684bd57eb47b915bd37987912518b96181
Author: jkovba <[email protected]>
Date:   2016-08-02T00:30:27Z

    Changed getQueryName to getQueryID in a few places.

commit 60e8e0599f969d146bdb580e11ab63b8188bb6ce
Author: Joseph Kovba <[email protected]>
Date:   2016-08-02T00:50:18Z

    Added a change

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to