Github user DarinJ commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/43#discussion_r73237838
--- Diff:
src/main/java/org/apache/pirk/querier/wideskies/QuerierDriverCLI.java ---
@@ -239,12 +242,19 @@ private boolean parseOptions()
}
SystemConfiguration.setProperty(CERTAINTY,
getOptionValue(CERTAINTY));
- if (!hasOption(QUERYNAME))
+ if (!hasOption(QUERYID))
{
- logger.info("Must have the option " + QUERYNAME);
+ logger.info("Must have the option " + QUERYID);
return false;
}
- SystemConfiguration.setProperty(QUERYNAME,
getOptionValue(QUERYNAME));
+
+ // create a formatted date/time string
+ Date date = new Date();
+ SimpleDateFormat sdf = new SimpleDateFormat("MM.dd.yyyy_hh.mm.ss");
+ String formattedDate = sdf.format(date);
--- End diff --
According to: https://pirk.incubator.apache.org/for_users, the required JDK
is 1.7. I'm pro 1.8, but that's not the subject of this PR. Was the decision
made to drop 1.7 support?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
