GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/56
PIRK-48 - Pirk should pass all FindBugs tests
- Address a number of FindBugs warnings, including
- Unused local variables.
- Inefficient use of keySet()-get() rather than entrySet().
- Exposed collections marked as final.
- Streams not closed.
There are still 22 warnings outstanding after these fixes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk pirk-48
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 0ad8787eceb29bb63d16c5f258513dd7dde91eee
Author: Tim Ellison <[email protected]>
Date: 2016-08-12T11:06:50Z
PIRK-48 - Pirk should pass all FindBugs tests
- Address a number of FindBugs warnings, including
- Unused local variables.
- Inefficient use of keySet()-get() rather than entrySet().
- Exposed collections marked as final.
- Streams not closed.
There are still 22 warnings outstanding after these fixes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
