On 12/08/16 16:15, Suneel Marthi wrote: > Most Apache committers I have known (most of Databricks, Hadoop vendors, > Data Artisans and others) are all IntelliJ users and IntelliJ has excellent > code inspection (much much better than Eclipse). I personally never had a > need for findbugs.
Let's not start that war ;-) I'll admit I have history with Eclipse. Seriously though, if you see IntelliJ flagging issues, don't assume Eclipse / FindBugs is showing the same ones and send in a patch. As I mention in the PR, the patch I offered still leaves 22 FindBugs issues unresolved, and I currently have 62 Eclipse warnings flagged up in the IDE -- so it is a non-trivial, but tractable task to address these. I'm a fan of code analysis tools. Are you aware of any Maven plug-ins we can add to the CI system (beyond FindBugs) that we should be considering? Regards, Tim > On Fri, Aug 12, 2016 at 11:06 AM, Tim Ellison <[email protected]> wrote: > >> On 12/08/16 14:16, Ellison Anne Williams wrote: >>> For Eclipse users, there is a Findbugs Eclipse plugin that is super easy >> to >>> use. You can find it here: >>> >>> https://marketplace.eclipse.org/content/findbugs-eclipse-plugin >> >> Yep, I agree. Though I hear rumours that not everybody is an Eclipse >> user?! >> >> Regards, >> Tim >> >> >
