Agree, they should be merged to master. Please go ahead and do it.
On Mon, Aug 15, 2016 at 11:17 AM, Tim Ellison <[email protected]> wrote: > Suneel, > > I know you have marked this as WIP, but they look good, why not merge > them now to master so they don't get stale? The release branch 0.1.0 > would be unaffected. > > Regards, > Tim > > > On 14/08/16 18:57, smarthi wrote: > > GitHub user smarthi opened a pull request: > > > > https://github.com/apache/incubator-pirk/pull/62 > > > > [WIP - Do not Merge] Fix code warnings > > > > > > > > You can merge this pull request into a Git repository by running: > > > > $ git pull https://github.com/smarthi/incubator-pirk Flink-pirk > > > > Alternatively you can review and apply these changes as the patch at: > > > > https://github.com/apache/incubator-pirk/pull/62.patch > > > > To close this pull request, make a commit to your master/trunk branch > > with (at least) the following in the commit message: > > > > This closes #62 > > > > ---- > > commit c2193e23235d0c8ebaef59738b42775d72aa2ec6 > > Author: smarthi <[email protected]> > > Date: 2016-08-14T17:56:27Z > > > > [WIP] Fix code warnings from IntelliJ > > > > ---- > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at [email protected] or file a JIRA > ticket > > with INFRA. > > --- > > >
