Github user smarthi commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/74#discussion_r75534791
--- Diff:
src/main/java/org/apache/pirk/responder/wideskies/ResponderDriver.java ---
@@ -65,6 +66,13 @@ else if
(SystemConfiguration.getProperty(ResponderProps.PLATFORM).equals("spark"
ComputeResponse computeResponse = new ComputeResponse(fs);
computeResponse.performQuery();
}
+ else if
(SystemConfiguration.getProperty(ResponderProps.PLATFORM).equals("storm"))
--- End diff --
we will need to abstract this out to implement this as a Strategy Pattern -
the more backends we add like Flink, Spark, Beam and others in the future its
only gonna get messy with multi - if-else stmts.
For a fun context, let me point u to this code snippet from IBM SystemML,
they r now adding Flink support which would be another another if-else block of
code - https://gist.github.com/smarthi/eb848e46621b7444924f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
