(Disclaimer, I'm verifying the source-release.zip in the staging repo only)
* xsums/sigs are good
* KEYS file contains signing key and is in dist.a.o
* Did not find any unexpected binary files
* Can build from source
* Can run tests and they pass (PaillierTest took a massive 272s though)
* DISCLAIMER is present
* No copyright notices in license headers
* RAT check passes
Some other comments:
* Licensing on shaded jar needs some work, but doesn't need to block
this release (amazing job on the licensing so far though, I can see a
lot of effort put into this already!)
* For the future, it's customary to also include an "rcX" in the VOTE
subject to disambiguate multiple "Apache Pirk 0.1.0" votes.
* In docs/resources/*.gif, what's the origin on these? I see that they
came in via the original import. I just wanted to double-check that
these were unique creations by someone in the original codebase (and not
copied without attribution).
+1 (binding)
- Josh
Ellison Anne Williams wrote:
Hi,
This is the vote for release 0.1.0 of Apache Pirk (incubating); it is a
source-only release (no binary artifacts).
The vote will run for at least 72 hours and will be closed on Wednesday,
August 24, 2016.
The artifacts can be downloaded here:
https://repository.apache.org/content/repositories/orgapachepirk-1002
All JIRAs completed for this release are tagged with 'FixVersion = 0.1.0'.
You can view the release note here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320320&version=12338109
The artifacts have been signed with Key : 1FD8849B
Please vote accordingly:
[ ] +1, accept RC as the official 0.1.0 release
[ ] -1, do not accept RC as the official 0.1.0 release because...
Thanks!
Ellison Anne
