Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/75#discussion_r75758251
--- Diff: src/main/java/org/apache/pirk/query/wideskies/Query.java ---
@@ -136,89 +124,30 @@ public boolean containsElement(BigInteger element)
return queryElements.containsValue(element);
}
- public void clearElements()
- {
- queryElements.clear();
- }
-
/**
* This should be called after all query elements have been added in
order to generate the expTable. For int exponentiation with BigIntegers,
assumes that
* dataPartitionBitSize < 32.
- *
*/
- public void generateExpTable(int numThreads) throws InterruptedException
+ public void generateExpTable()
--- End diff --
I want to draw attention to this part of the new code, that will use the
```ForkJoinPool#commonPool()``` (i.e. all available processors by default). We
can put this into a smaller custom pool if it is desirable to have that
restriction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
